mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.
Date Thu, 17 Mar 2016 14:59:58 GMT


> On March 12, 2016, 2:45 a.m., Avinash sridharan wrote:
> > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 277
> > <https://reviews.apache.org/r/44706/diff/1/?file=1295806#file1295806line277>
> >
> >     either s/realpath/`realpath`
> >     
> >     or s/realpath/location

I see cgroups.cpp uses the word `canonical path` which I think is good, so let's just use
it :-)


> On March 12, 2016, 2:45 a.m., Avinash sridharan wrote:
> > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 358
> > <https://reviews.apache.org/r/44706/diff/1/?file=1295806#file1295806line358>
> >
> >     If we block here, it will lock the isolator, and prevent the `MesosContainerizer`
from launching any more containers?
> 
> Qian Zhang wrote:
>     I do not think it will prevent `MesosContainerizer` from launching any more containers.
Please take a look at: https://github.com/apache/mesos/blob/0.27.2/src/slave/containerizer/mesos/containerizer.cpp#L945:L1034,
the whole code to call launcher to fork executor process and call isolator's `isolate()` are
already in a `defer()` as a lambda, and it is also a very big lambda.
> 
> Avinash sridharan wrote:
>     Hi Qian,
>      Didn't understand your comment. Are you implying calling `await` on the `Future`
won't block?

I think it will not block `MesosContainerizerProcess`, but it will indeed block `NetworkCniIsolatorProcess`.
So yes, I agree we should use `defer`. And I have another question, for the container which
want to join multiple networks, do we want to call plugin to join multiple networks in parallel
or sequentially? I think joining one network should be independent on joining another, but
if we do them in parallel, I am afraid that user may see "`eth2, eth0, eth1`" rather than
"`eth0, eth1, eth2`" in the container. Please let me know your thought :-)


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44706/#review123181
-----------------------------------------------------------


On March 16, 2016, 3:50 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44706/
> -----------------------------------------------------------
> 
> (Updated March 16, 2016, 3:50 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
>     https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented isolate() method of "network/cni" isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44706/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message