mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Schad <jo...@mesosphere.io>
Subject Re: Review Request 44767: Added authentication information to master endpoints.
Date Thu, 17 Mar 2016 12:01:48 GMT


> On March 14, 2016, 10:51 p.m., Greg Mann wrote:
> > docs/endpoints/master/create-volumes.md, line 24
> > <https://reviews.apache.org/r/44767/diff/2/?file=1296936#file1296936line24>
> >
> >     I wonder if the shorthand "iff" might be a bit too esoteric for these help strings?

We actually use it at several places in HELP master endpoint strings.
E.g., '''Returns 200 OK iff the Master is healthy.'''.
No strong opinion happy to change (not now this has moved to the earlier review).


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44767/#review123522
-----------------------------------------------------------


On March 17, 2016, 11:57 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44767/
> -----------------------------------------------------------
> 
> (Updated March 17, 2016, 11:57 a.m.)
> 
> 
> Review request for mesos, Adam B and Greg Mann.
> 
> 
> Bugs: MESOS-4934
>     https://issues.apache.org/jira/browse/MESOS-4934
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Master endpoints now display information whether authentication (if enabled) is required
in HELP.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp b47ab7cc86c0a56a81815a98bd63f37a1175ba7f 
> 
> Diff: https://reviews.apache.org/r/44767/diff/
> 
> 
> Testing
> -------
> 
> Viewed master endpoint help in browser.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message