mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly
Date Wed, 16 Mar 2016 19:59:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33174/#review123913
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/docker.cpp (lines 1069 - 1076)
<https://reviews.apache.org/r/33174/#comment186218>

    The indentation here should be 2 (instead of 4) since you're at it (I was planning to
fix it for you before commit).



src/slave/containerizer/docker.cpp (line 1075)
<https://reviews.apache.org/r/33174/#comment186219>

    The indentation here should be 2 as well.



src/slave/containerizer/docker.cpp (line 1321)
<https://reviews.apache.org/r/33174/#comment186226>

    Can you add a NOTE about what does 'force' mean in the header file?


- Jie Yu


On March 16, 2016, 7:15 p.m., Steve Niemitz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33174/
> -----------------------------------------------------------
> 
> (Updated March 16, 2016, 7:15 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2617
>     https://issues.apache.org/jira/browse/MESOS-2617
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix for docker containerizer not configuring CFS quotas correctly.
> 
> It would be nice to refactor all this isolation code in a way that can be shared between
all containerizers, as this is basically just copied from the CgroupsCpushareIsolator, but
that's a much bigger undertaking.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.hpp 79cd955e9c241becff52cc4bbef81dcc16802ee7 
>   src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
> 
> Diff: https://reviews.apache.org/r/33174/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Steve Niemitz
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message