mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 44708: Fixed signed / unsigned comparison in docker.cpp.
Date Tue, 15 Mar 2016 22:54:30 GMT


> On March 15, 2016, 10:37 p.m., Ben Mahler wrote:
> > src/slave/constants.hpp, line 102
> > <https://reviews.apache.org/r/44708/diff/3/?file=1299828#file1299828line102>
> >
> >     We tend to use size_t for things that are a count or a size. Otherwise, we'll
tend to use `unsigned int` rather than uint32_t.

Right, here I picked `uint32_t` for consistency with all other unsigned constants in this
file.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44708/#review123774
-----------------------------------------------------------


On March 15, 2016, 2:28 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44708/
> -----------------------------------------------------------
> 
> (Updated March 15, 2016, 2:28 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp 0b4e41b4eee3280515cf8a1f049fe923503066f1 
> 
> Diff: https://reviews.apache.org/r/44708/diff/
> 
> 
> Testing
> -------
> 
> The complete chain was tested. See https://reviews.apache.org/r/44662/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message