mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Schad <jo...@mesosphere.io>
Subject Re: Review Request 44652: Omitted names of unused parameters in command executor.
Date Tue, 15 Mar 2016 11:13:31 GMT


> On March 10, 2016, 5:56 p.m., Joerg Schad wrote:
> > src/launcher/executor.cpp, line 124
> > <https://reviews.apache.org/r/44652/diff/1/?file=1294474#file1294474line124>
> >
> >     Not sure whether we have a real style for that, but the example I seen (and
used myself) are to comment the name. See https://github.com/apache/mesos/blob/master/3rdparty/libprocess/src/openssl.cpp#L155
for an example.
> >     In this case I don't believe it makes a large difference as the Type is descriptive
enough, but that might be different with more general types (imagine a string).
> 
> Ben Mahler wrote:
>     The openssl file is pretty new, I think the general style for this has not been to
use `/* */` comments but rather to leave the name or omit the name.

I guess the Google Styleguide (https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions)
states "Unused parameters that are obvious from context may be omitted:" and " Unused parameters
that might not be obvious should comment". So I would agree that in this case it is obvious
and hence could be omited.


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44652/#review122944
-----------------------------------------------------------


On March 14, 2016, 5:48 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44652/
> -----------------------------------------------------------
> 
> (Updated March 14, 2016, 5:48 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp 4149f084b0b234fb995df04e9d1ca704feec082e 
> 
> Diff: https://reviews.apache.org/r/44652/diff/
> 
> 
> Testing
> -------
> 
> The complete chain was tested. See https://reviews.apache.org/r/44662/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message