mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.
Date Tue, 15 Mar 2016 08:45:13 GMT


> On March 4, 2016, 8:42 a.m., Benjamin Bannier wrote:
> > I think using a `TemporaryDirectoryTest` fixture is the right approach, but what
I find unfortunate about your approach is that with this patch we'd create a temporary directory
and incur the overhead for all tests in this suite, even ones not creating any files. If that's
something we wouldn't want, what about using separate suites for tests creating files (that
would be `BufferedRead` and `Redirect`), and other ones?
> 
> Yong Tang wrote:
>     Hi Benjamin, thanks for the suggestion. I splits IOTest into two test suites. Those
tests that will not write files to disk remains the same while the rests (BufferedRead and
Redirect) have been moved to TemporaryDirectoryIOTest via TemporaryDirectoryTest fixture.
Let me see if there are any issues and I will fix it.
> 
> Yong Tang wrote:
>     Hi Benjamin, are there any additional issues that need to be addressed in this review
request? Feedback is appreciated.

Yong, you still need to find a committer to shepherd this patch for you.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/#review122030
-----------------------------------------------------------


On March 15, 2016, 2:38 a.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44380/
> -----------------------------------------------------------
> 
> (Updated March 15, 2016, 2:38 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-4807
>     https://issues.apache.org/jira/browse/MESOS-4807
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit changes IOTest.BufferedRead so that this specific
> test (not all IOTest) could be executed from temporary
> directories via TemporaryDirectoryTest fixture (MESOS-4807).
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/io_tests.cpp 2bffc7cd9c3aa204a1d1b8eb45f0bff12f49ca62

> 
> Diff: https://reviews.apache.org/r/44380/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message