mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 44766: Enabled Authentication information in endpoint HELP.
Date Mon, 14 Mar 2016 22:55:28 GMT


> On March 14, 2016, 8:28 a.m., Adam B wrote:
> > 3rdparty/libprocess/src/help.cpp, line 43
> > <https://reviews.apache.org/r/44766/diff/3/?file=1296962#file1296962line43>
> >
> >     What if this was a bool instead of a string? How many values do you expect?

I agree that we should be able to auto-generate the text associated with authentication being
enabled or disabled. The one thing we *might* want to pass through is the authentication realm
that the endpoint is associated with? This could become relevant in the future if we allow
enabling/disabling authentication on a per-endpoint basis. But since we don't do that currently,
perhaps a boolean would be sufficient?


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44766/#review123377
-----------------------------------------------------------


On March 13, 2016, 10:31 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44766/
> -----------------------------------------------------------
> 
> (Updated March 13, 2016, 10:31 p.m.)
> 
> 
> Review request for mesos, Adam B and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enabled endpoint HELP string to display information about authentication requirements.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/help.hpp 783304e2fc78db70f1a5fccbf5e96fcc76a88fd8

>   3rdparty/libprocess/src/help.cpp 5f368801affecacb0d1daaeb6ccf5895ccb231d2 
>   3rdparty/libprocess/src/logging.cpp 015a43db77fd7015aeee0c45fa10c292f3e9cf58 
> 
> Diff: https://reviews.apache.org/r/44766/diff/
> 
> 
> Testing
> -------
> 
> Viewed master endpoint help in browser.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message