mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhishek Dasgupta <a10gu...@linux.vnet.ibm.com>
Subject Re: Review Request 44439: Added device support in cgroups abstraction.
Date Mon, 14 Mar 2016 19:56:22 GMT


> On March 9, 2016, 1:58 a.m., Ben Mahler wrote:
> > src/tests/containerizer/cgroups_tests.cpp, lines 1278-1309
> > <https://reviews.apache.org/r/44439/diff/2/?file=1282331#file1282331line1278>
> >
> >     Does this test pass? Did you make sure this test ran? Note that you have to
run the tests under 'sudo' on Linux for this test to run because it has the ROOT and CGROUPS
strings in the test name.

Hi,

I actually ran these tests. And here is the output:

[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from CgroupsAnyHierarchyDevicesTest
[ RUN      ] CgroupsAnyHierarchyDevicesTest.ROOT_CGROUPS_Devices
[       OK ] CgroupsAnyHierarchyDevicesTest.ROOT_CGROUPS_Devices (10 ms)
[----------] 1 test from CgroupsAnyHierarchyDevicesTest (10 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (31 ms total)
[  PASSED  ] 1 test.
make[3]: Leaving directory '/home/abhishek/test/mesos/build/src'
make[2]: Leaving directory '/home/abhishek/test/mesos/build/src'

devices.list can't be changed by writing on it. It is to be changed by writing in devices.deny
or device.allow. I followed this logic developing the code. Please, contradict me if I am
wrong in any assumption/deduction.


- Abhishek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44439/#review122646
-----------------------------------------------------------


On March 14, 2016, 6:25 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44439/
> -----------------------------------------------------------
> 
> (Updated March 14, 2016, 6:25 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Felix Abecassis, Kevin Klues, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3368
>     https://issues.apache.org/jira/browse/MESOS-3368
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> There are some helper methods added to support device cgroups in cgroups abstraction
to aid isolators controlling access to devices.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.hpp 51ccefd1fd2d0989b9bd31342d3d1e3701f88ed2 
>   src/linux/cgroups.cpp df18ed46a2a96871f67c7eb4233c3b4c27b7aa1c 
>   src/tests/containerizer/cgroups_tests.cpp acaed9b3f8a04964092cef413133834d0cf5a145

> 
> Diff: https://reviews.apache.org/r/44439/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message