mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 44087: Moved logic to assign process to freezer hierarchy into parentHook.
Date Mon, 14 Mar 2016 18:25:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44087/#review123473
-----------------------------------------------------------



Patch looks great!

Reviews applied: [44790, 44791, 44087]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 14, 2016, 3:44 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44087/
> -----------------------------------------------------------
> 
> (Updated March 14, 2016, 3:44 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4839
>     https://issues.apache.org/jira/browse/MESOS-4839
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously assigning the process to the freezer hierarchy basically reimplemented the
same blocking and error handling logic provided by parentHooks.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/linux_launcher.cpp 9c80cfb621ef2e28aabfb2649846892964d2d4f3

> 
> Diff: https://reviews.apache.org/r/44087/diff/
> 
> 
> Testing
> -------
> 
> sudo make check (on Linux)
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message