mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Schad <jo...@mesosphere.io>
Subject Re: Review Request 44790: Refactored Error behavior of 'extendLifetime' parentHook.
Date Mon, 14 Mar 2016 15:44:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44790/
-----------------------------------------------------------

(Updated March 14, 2016, 3:44 p.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-4839
    https://issues.apache.org/jira/browse/MESOS-4839


Repository: mesos


Description
-------

Previously the Error behavior (in particular where the child process is killed) was not consistent
among Error cases.
We should establish the convention that the Hook itself returns an error, while the subprocess
code is resposible for
killing the child process in case of such Error.


Diffs
-----

  src/linux/systemd.hpp 6b240b9cc2fe559d111a4235e70f00e07f3d4495 
  src/linux/systemd.cpp e120d2ceffe6bb400859f2a132f02a99f561f856 

Diff: https://reviews.apache.org/r/44790/diff/


Testing
-------

sudo make check (on Linux)


Thanks,

Joerg Schad


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message