mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Schad <jo...@mesosphere.io>
Subject Review Request 44791: Changed subprocess comment to reflect Error handling of parent Hooks.
Date Mon, 14 Mar 2016 15:42:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44791/
-----------------------------------------------------------

Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
-------

Previously the Error behavior (in particular where the child process is killed) was not consistent
among Error cases.
We should establish the convention that the Hook itself returns an error, while the subprocess
code is resposible for
killing the child process in case of such Error.


Diffs
-----

  3rdparty/libprocess/src/subprocess.cpp 16c327db6fde1a1bac92d9e8f7cc80e57b028c1a 

Diff: https://reviews.apache.org/r/44791/diff/


Testing
-------

sudo make check (on Linux)


Thanks,

Joerg Schad


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message