mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.
Date Sun, 13 Mar 2016 11:23:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43819/#review123309
-----------------------------------------------------------


Fix it, then Ship it!




Looks great. Fix it, then I'll commit.


docs/app-framework-development-guide.md (line 136)
<https://reviews.apache.org/r/43819/#comment185526>

    s/necessarily/usually/ It's only implemented by a framework if it's not using libmesos,
right?



docs/app-framework-development-guide.md (lines 324 - 325)
<https://reviews.apache.org/r/43819/#comment185527>

    Looks like this fits on one line now. I wonder if others will too.


- Adam B


On March 7, 2016, 12:14 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43819/
> -----------------------------------------------------------
> 
> (Updated March 7, 2016, 12:14 p.m.)
> 
> 
> Review request for mesos, Adam B and Neil Conway.
> 
> 
> Bugs: MESOS-4726
>     https://issues.apache.org/jira/browse/MESOS-4726
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously the app-framework-development-guide only explained the scheduler callback
interface. Equally important when developing frameworks is the knowledge if potential actions
a scheduler can trigger via the SchedulerDriver.
> 
> 
> Diffs
> -----
> 
>   docs/app-framework-development-guide.md 55f09c7cf2262dda98dcc8b63b1e36ab78296141 
> 
> Diff: https://reviews.apache.org/r/43819/diff/
> 
> 
> Testing
> -------
> 
> Viewed via gist (https://gist.github.com/joerg84/b4bf279a55e1b62051e6) and via docker
website container.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message