mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 44620: Documented how to make executors work with SSL.
Date Sun, 13 Mar 2016 08:51:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44620/#review123305
-----------------------------------------------------------


Ship it!




Looks good, but I'll clean it up a bit before committing, if you don't mind:

Executors must be able to access the SSL environment variables and the files referred to by
those variables. Environment variables can be provided to an executor by specifying `CommandInfo.environment`
or by using the slave's `--executor_environment_variables` command line flag. If the slave
and the executor are running in separate containers, `ContainerInfo.volumes` can be used to
mount SSL files from the host into the executor's container.

- Adam B


On March 11, 2016, 11:11 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44620/
> -----------------------------------------------------------
> 
> (Updated March 11, 2016, 11:11 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-4750
>     https://issues.apache.org/jira/browse/MESOS-4750
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Documented how to make executors work with SSL.
> 
> 
> Diffs
> -----
> 
>   docs/ssl.md 3de2a3e931091e002dc4b259c70eadd89a52b059 
> 
> Diff: https://reviews.apache.org/r/44620/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message