mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 44703: Added Doxygen docs for basic HTTP authenticator.
Date Fri, 11 Mar 2016 14:52:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44703/#review123140
-----------------------------------------------------------




include/mesos/authentication/http/basic_authenticator_factory.hpp (lines 46 - 54)
<https://reviews.apache.org/r/44703/#comment185311>

    I think this might be a bit confusing because this json is not a valid parameter value,
while one gains in the sense that it reflects the intention, I can imagine people using this
as an example, feeding it into the `--modules` flag, and then failing. So I rather use the
actual json users have to write even if it looks worse.


- Alexander Rojas


On March 11, 2016, 10:47 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44703/
> -----------------------------------------------------------
> 
> (Updated March 11, 2016, 10:47 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4849
>     https://issues.apache.org/jira/browse/MESOS-4849
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added Doxygen docs for basic HTTP authenticator.
> 
> The structure of the module parameters for the basic HTTP authenticator has changed,
so Doxygen comments were added to the module's header file to provide an example.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authentication/http/basic_authenticator_factory.hpp c11bb47c8e02f2e8645cf387d18eb64d1c8cb604

> 
> Diff: https://reviews.apache.org/r/44703/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message