mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <>
Subject Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.
Date Fri, 11 Mar 2016 09:39:11 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 11, 2016, 9:39 a.m.)

Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till Toenshoff.


Addressed comment.

Bugs: MESOS-4850

Repository: mesos


Modified basic HTTP authenticator creator to accept realm.

To accommodate different authentication realms for the master and agent, the default basic
HTTP authenticator needs to accept its authentication realm as a parameter. This patch adds
this parameter and modifies the HTTP authentication tests to validate it appropriately.

Diffs (updated)

  include/mesos/authentication/http/basic_authenticator_factory.hpp c11bb47c8e02f2e8645cf387d18eb64d1c8cb604

  src/authentication/http/basic_authenticator_factory.cpp 62f851685db3b42c52bbcb7cff3e4f4703004ed7

  src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc 
  src/tests/http_authentication_tests.cpp cf2bb762272fa38e04e5c26aef2858300bbd0459 



`make check` was used to test on both OSX and CentOS 7.


Greg Mann

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message