mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 44690: Added 'delegate' info to the Help process.
Date Fri, 11 Mar 2016 03:11:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44690/
-----------------------------------------------------------

(Updated March 11, 2016, 3:11 a.m.)


Review request for mesos, Ben Mahler and Neil Conway.


Changes
-------

Accidentally introduced unwanted change in last revision.  Updated to remove it.


Bugs: MESOS-4787
    https://issues.apache.org/jira/browse/MESOS-4787


Repository: mesos


Description
-------

Just as the ProcessManager needs the delegate name to know which
process to service root HTTP requests from, the Help process needs to
know the delegate name so it can generate the proper USAGE strings.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/help.hpp 93306adfd64cc08933232e0db78d9efacb966018 
  3rdparty/libprocess/src/help.cpp bac980ddec98b34bdfd786b03d0691fefb93f45a 
  3rdparty/libprocess/src/process.cpp 01bc19bc6f4d78923bb3796b7dd0a9ab2b3108d1 

Diff: https://reviews.apache.org/r/44690/diff/


Testing
-------

I spun up a master and an agent and looked at their /help endpoint to verify that the updated
USAGE strings include information about accessing the enpoint without the process name.


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message