mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Review Request 44689: Changed ProcessManager.delegate to an Option<string> type.
Date Fri, 11 Mar 2016 01:38:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44689/
-----------------------------------------------------------

Review request for mesos, Ben Mahler and Neil Conway.


Bugs: MESOS-4914
    https://issues.apache.org/jira/browse/MESOS-4914


Repository: mesos


Description
-------

Previously it was just a string type and we checked for 'existence' of
a delegate by comparing (delegate != ""). Using an Option is the
preferred method for things like this.


Diffs
-----

  3rdparty/libprocess/include/process/process.hpp 45ccf9d0461ed2f6dbb0f5084839582d6be3dd1c

  3rdparty/libprocess/src/process.cpp 01bc19bc6f4d78923bb3796b7dd0a9ab2b3108d1 

Diff: https://reviews.apache.org/r/44689/diff/


Testing
-------

I recompiled mesos and ran 'make check'.


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message