mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 44456: Added Appc provisioner integration test.
Date Fri, 11 Mar 2016 00:59:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44456/#review123055
-----------------------------------------------------------




src/tests/containerizer/provisioner_appc_tests.cpp (lines 805 - 845)
<https://reviews.apache.org/r/44456/#comment185181>

    Can you move all these to the test fixture? I'd like to see all preparation done in SetUp
    
    Also, I think for integration tests, we can just use file based. No need for the server
as well.


- Jie Yu


On March 8, 2016, 10:50 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44456/
> -----------------------------------------------------------
> 
> (Updated March 8, 2016, 10:50 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4818
>     https://issues.apache.org/jira/browse/MESOS-4818
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added Appc provisioner integration test.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_appc_tests.cpp 6c8087e17aa8b7139ba12337d5be472b7099e77f

> 
> Diff: https://reviews.apache.org/r/44456/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message