mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 44469: Implemented runtime isolator default cmd test.
Date Thu, 10 Mar 2016 23:38:35 GMT


> On March 9, 2016, 3:22 p.m., Jie Yu wrote:
> > src/tests/containerizer/runtime_isolator_tests.cpp, line 102
> > <https://reviews.apache.org/r/44469/diff/1/?file=1283306#file1283306line102>
> >
> >     Can you put this under slave's work dir?

Because if all tests using the same dir for docker store, once the first test cache the manifest,
but the following tests using different manifest with different entrypont/cmd, it will be
problematic.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44469/#review122830
-----------------------------------------------------------


On March 10, 2016, 3:37 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44469/
> -----------------------------------------------------------
> 
> (Updated March 10, 2016, 3:37 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented runtime isolator default cmd test.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/runtime_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44469/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> sudo ./bin/mesos-tests.sh
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message