mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.
Date Thu, 10 Mar 2016 05:21:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/#review122879
-----------------------------------------------------------



Can you also update the documentation? In particular, `docs/persistent-volume.md`, `docs/reservation.md`,
and add a note about the backward-incompatible change to `upgrades.md`.


src/tests/persistent_volume_endpoints_tests.cpp (line 60)
<https://reviews.apache.org/r/44606/#comment184965>

    "using" directives should be sorted alphabetically.


- Neil Conway


On March 10, 2016, 3:41 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44606/
> -----------------------------------------------------------
> 
> (Updated March 10, 2016, 3:41 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Modify the return code of the following endpoints to 202:
> 1. /reserve
> 2. /unreserve
> 3. /create-volumes
> 4. /destroy-volumes
> 
> [#MESOS-4580]
> 
> Signed-off-by: Guo Jiannan <guojiannan@cn.ibm.com>
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp a3ad57a1c3f8a01aa609b28c12825670bb243387 
>   src/tests/persistent_volume_endpoints_tests.cpp 81185a161498394020a27f1f5bf747bac5425f43

>   src/tests/reservation_endpoints_tests.cpp f95ae7a32c3809d150adf1e9e515a3b527e61699

> 
> Diff: https://reviews.apache.org/r/44606/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message