mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.
Date Wed, 09 Mar 2016 20:10:46 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 9, 2016, 12:10 p.m.)

Review request for mesos, Benjamin Hindman, Bernd Mathiske, Artem Harutyunyan, and Michael


Change Master/Slave default constructor to use the `default` keyword.

Bugs: MESOS-4633 and MESOS-4634

Repository: mesos


Major rewrite of the `tests/cluster` helpers.  This strongly ties the scope of test objects
to the test body.

Changes the `Cluster` class into two RAII objects (`Master` and `Slave`).  The `Slave` object
performs cleanup originally found in `cluster::Slave::stop`.  `cluster::Master::start` and
`cluster::Slave::start` were changed to factory methods.

Diffs (updated)

  src/tests/cluster.hpp 99a785ab0d4ee1a1e745202d2551de58a7631a85 
  src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625 



Tests are run at the end of this review chain.


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message