mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jojy Varghese <j...@mesosphere.io>
Subject Re: Review Request 44299: Added unit test for file URI fetcher.
Date Tue, 08 Mar 2016 23:25:03 GMT


> On March 8, 2016, 1:57 a.m., Jie Yu wrote:
> > src/tests/containerizer/provisioner_appc_tests.cpp, lines 590-591
> > <https://reviews.apache.org/r/44299/diff/2/?file=1280158#file1280158line590>
> >
> >     Looking at the original code, why do we need this id? Should that always be
the same? Why do we need to pass it in?

moved the image id up to `prepareImage` method.


- Jojy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44299/#review122461
-----------------------------------------------------------


On March 8, 2016, 10:49 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44299/
> -----------------------------------------------------------
> 
> (Updated March 8, 2016, 10:49 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unit test for file URI fetcher.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_appc_tests.cpp 6c8087e17aa8b7139ba12337d5be472b7099e77f

> 
> Diff: https://reviews.apache.org/r/44299/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message