mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jojy Varghese <j...@mesosphere.io>
Subject Review Request 44534: Refactored AppcImageFetcherTest.
Date Tue, 08 Mar 2016 22:47:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44534/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Repository: mesos


Description
-------

Changes:
  - Changed TestAppcImageServer mock methods to real implementation that
  serves http requests. This will allow the TestAppcImageServer to serve
  multiple images in a test.
  - Made TestAppcImageServer loadable so that it can serve images from its
  'images' directory (currently defaulted to 'server').
  - Renamed prepareServerImage to prepareImage to reflect the semantics.


Diffs
-----

  src/tests/containerizer/provisioner_appc_tests.cpp 6c8087e17aa8b7139ba12337d5be472b7099e77f


Diff: https://reviews.apache.org/r/44534/diff/


Testing
-------

make check.


Thanks,

Jojy Varghese


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message