mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 44269: Added the framework of 'network/cni' isolator.
Date Tue, 08 Mar 2016 18:09:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44269/#review122546
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/network/cni.cpp (line 49)
<https://reviews.apache.org/r/44269/#comment184627>

    How about using `'--network_cni_plugins_dir'`?



src/slave/containerizer/mesos/isolators/network/cni.cpp (line 54)
<https://reviews.apache.org/r/44269/#comment184628>

    ditto.



src/slave/containerizer/mesos/isolators/network/cni.cpp (lines 58 - 60)
<https://reviews.apache.org/r/44269/#comment184633>

    return Error(
        "The Network CNI plugins directory '" +
        flags.network_cni_plugins_dir.get() + "' does not exist");



src/slave/containerizer/mesos/isolators/network/cni.cpp (lines 65 - 66)
<https://reviews.apache.org/r/44269/#comment184634>

    ditto.



src/slave/containerizer/mesos/isolators/network/cni.cpp (lines 95 - 288)
<https://reviews.apache.org/r/44269/#comment184640>

    I would strongly recommend move all `parse` and `validation` operations to `spec.cpp`,
because we may not want the `create` method to be that long.


- Gilbert Song


On March 8, 2016, 6:42 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44269/
> -----------------------------------------------------------
> 
> (Updated March 8, 2016, 6:42 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
>     https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the framework of 'network/cni' isolator.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 8f57a5701073bf1eaaa223383e928cf5db8f8ae4 
>   src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
>   src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/spec.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44269/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message