mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 44299: Added unit test for file URI fetcher.
Date Tue, 08 Mar 2016 01:57:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44299/#review122461
-----------------------------------------------------------




src/tests/containerizer/provisioner_appc_tests.cpp (lines 587 - 588)
<https://reviews.apache.org/r/44299/#comment184457>

    Looking at the original code, why do we need this id? Should that always be the same?
Why do we need to pass it in?



src/tests/containerizer/provisioner_appc_tests.cpp (lines 591 - 592)
<https://reviews.apache.org/r/44299/#comment184459>

    I don't like this. Sounds like to try very hard to reuse the same fixture, but that causes
a lot of confusion. Let's chat about this tomorrow.



src/tests/containerizer/provisioner_appc_tests.cpp (line 665)
<https://reviews.apache.org/r/44299/#comment184458>

    It looks weired to me that FileFetch test will use a 'Server'. It's very confusing. I
understand that you want to re-use the same helper. Can we rename the helper and change the
semantics to just create an image tarball? Let's chat about this tomorrow.


- Jie Yu


On March 3, 2016, 11:37 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44299/
> -----------------------------------------------------------
> 
> (Updated March 3, 2016, 11:37 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unit test for file URI fetcher.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_appc_tests.cpp 6c8087e17aa8b7139ba12337d5be472b7099e77f

> 
> Diff: https://reviews.apache.org/r/44299/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message