mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Mahler <benjamin.mah...@gmail.com>
Subject Re: Review Request 44379: Correctly parse perf stat format for 3.10 kernel.
Date Tue, 08 Mar 2016 01:35:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44379/#review122455
-----------------------------------------------------------




src/linux/perf.cpp (lines 430 - 431)
<https://reviews.apache.org/r/44379/#comment184454>

    Couple of thoughts here:
    
    (1) This comment is no longer accurate since there is a special case for 3.10. Would be
better to re-structure the last block of this else flow to better reflect the new logic.
    
    (2) What about 3.11? Is it the same as 3.10? It would be surprising if 3.11 and < 3.10
are the same, but 3.10 is different.


- Ben Mahler


On March 4, 2016, 6:28 a.m., fan du wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44379/
> -----------------------------------------------------------
> 
> (Updated March 4, 2016, 6:28 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-4705
>     https://issues.apache.org/jira/browse/MESOS-4705
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Correctly parse perf stat format for 3.10 kernel.
> 
> 
> Diffs
> -----
> 
>   src/linux/perf.cpp 1c113a2b3f57877e132bbd65e01fb2f045132128 
> 
> Diff: https://reviews.apache.org/r/44379/diff/
> 
> 
> Testing
> -------
> 
> {Found and Test} with Serenity, ema filter could get perf event statistics correctly
as expected.
> 
> 
> Thanks,
> 
> fan du
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message