mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 44414: Added documentation about container image support.
Date Tue, 08 Mar 2016 00:51:47 GMT


> On March 6, 2016, 4:35 a.m., Guangya Liu wrote:
> > docs/container-image.md, lines 146-177
> > <https://reviews.apache.org/r/44414/diff/1/?file=1281645#file1281645line146>
> >
> >     What about move this to `## Docker Support`

I would rather not. I want to have a complete flow in the 'Getting started' section. We just
use docker as an example.


> On March 6, 2016, 4:35 a.m., Guangya Liu wrote:
> > docs/container-image.md, lines 216-220
> > <https://reviews.apache.org/r/44414/diff/1/?file=1281645#file1281645line216>
> >
> >     Suggest add the default value here: https://registry-1.docker.io
> >     
> >     s/The default URL/The URL

It's the default URL. If the user specify a registry in Docker.name, we won't use this value
(that's how we planned at least).


> On March 6, 2016, 4:35 a.m., Guangya Liu wrote:
> > docs/container-image.md, lines 228-237
> > <https://reviews.apache.org/r/44414/diff/1/?file=1281645#file1281645line228>
> >
> >     Can you please add some command line as Docker for how to test this out?

I'll do that later.


> On March 6, 2016, 4:35 a.m., Guangya Liu wrote:
> > docs/container-image.md, line 253
> > <https://reviews.apache.org/r/44414/diff/1/?file=1281645#file1281645line253>
> >
> >     move this word above?

I wrap all text using 70 width.


> On March 6, 2016, 4:35 a.m., Guangya Liu wrote:
> > docs/container-image.md, lines 273-279
> > <https://reviews.apache.org/r/44414/diff/1/?file=1281645#file1281645line273>
> >
> >     I filed an issue for this read-only mount point https://issues.apache.org/jira/browse/MESOS-4876
, so with a `bind` backend, the end user need to make sure that the `sandbox_directory` must
already exist for the rootfs. By defult, the docker images will not include a default sandbox
as `/mnt/mesos/sandbox`, the task will always be failed. Shall we highlight that it is better
to specify an existing sandbox when start agent?

or the image writer can make sure --sandbox_directory exists in the image.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44414/#review122221
-----------------------------------------------------------


On March 5, 2016, 2:20 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44414/
> -----------------------------------------------------------
> 
> (Updated March 5, 2016, 2:20 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jojy Varghese, Neil Conway, Timothy Chen, and
Vinod Kone.
> 
> 
> Bugs: MESOS-4873
>     https://issues.apache.org/jira/browse/MESOS-4873
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added documentation about container image support.
> 
> 
> Diffs
> -----
> 
>   docs/container-image.md PRE-CREATION 
>   docs/mesos-provisioner.md 1b19406cb93bbc3f5330eaf9d29b1be98a674136 
> 
> Diff: https://reviews.apache.org/r/44414/diff/
> 
> 
> Testing
> -------
> 
> Tested the formatting in Mou
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message