mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Klaus Ma <klaus1982...@gmail.com>
Subject Re: Review Request 37168: Add an example framework using dynamic reservation.
Date Mon, 07 Mar 2016 09:40:26 GMT


> On Feb. 23, 2016, 7:23 a.m., Joerg Schad wrote:
> > src/tests/dynamic_reservation_framework_test.sh, line 30
> > <https://reviews.apache.org/r/37168/diff/9/?file=1263708#file1263708line30>
> >
> >     Thy do we need this? Comparing to persistent_volume_framework_test.sh

After implicit role, it's unnecessary; removed. But before implicit role, it's required for
master to accept more role; it's a litte different with persistent_volume_framework test:
persistent_volume_frameowork_test uses test as default role, and considered it as reserved,
but we can not dynamical reserve resources on default role.


> On Feb. 23, 2016, 7:23 a.m., Joerg Schad wrote:
> > src/examples/dynamic_reservation_framework.cpp, line 217
> > <https://reviews.apache.org/r/37168/diff/9/?file=1263707#file1263707line217>
> >
> >     LOG(ERROR) << message; or at least add output indicating this is an error.

Add "Error: " to indicate it's an error.


- Klaus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37168/#review120212
-----------------------------------------------------------


On March 7, 2016, 5:20 p.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37168/
> -----------------------------------------------------------
> 
> (Updated March 7, 2016, 5:20 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Joerg Schad, and Michael Park.
> 
> 
> Bugs: MESOS-3063
>     https://issues.apache.org/jira/browse/MESOS-3063
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Provide example for dynamic reservation features.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
>   src/examples/dynamic_reservation_framework.cpp PRE-CREATION 
>   src/tests/dynamic_reservation_framework_test.sh PRE-CREATION 
>   src/tests/examples_tests.cpp 6ddac17bb2ac0330bcc09eaab975ae70e84a7695 
> 
> Diff: https://reviews.apache.org/r/37168/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message