mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.
Date Mon, 07 Mar 2016 09:36:33 GMT


> On Feb. 21, 2016, 7:20 p.m., Guangya Liu wrote:
> > docs/app-framework-development-guide.md, line 135
> > <https://reviews.apache.org/r/43819/diff/1/?file=1263766#file1263766line135>
> >
> >     Why not merge this and above `Scheduler API` into one section?
> 
> Joerg Schad wrote:
>     I wanted to keep the Scheduler API i.e. the callbacks the scheduler has to implement
and the calls it can make (i.e. SchedulerDriver API) seperate. Does that make sense?
> 
> Guangya Liu wrote:
>     What about name this part as Scheduler Driver API?

+100 to "Scheduler Driver API" rather than two "Scheduler API" headings

// Abstract interface for connecting a scheduler to Mesos. This
// interface is used both to manage the scheduler's lifecycle (start
// it, stop it, or wait for it to finish) and to interact with Mesos
// (e.g., launch tasks, kill tasks, etc.).
class SchedulerDriver


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43819/#review120091
-----------------------------------------------------------


On Feb. 21, 2016, 7 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43819/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2016, 7 p.m.)
> 
> 
> Review request for mesos, Adam B and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added Scheduler-Driver API to app-framework-development-guide.md.
> 
> 
> Diffs
> -----
> 
>   docs/app-framework-development-guide.md e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
> 
> Diff: https://reviews.apache.org/r/43819/diff/
> 
> 
> Testing
> -------
> 
> Viewed via gist (https://gist.github.com/joerg84/b4bf279a55e1b62051e6) and via docker
website container.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message