mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.
Date Sat, 05 Mar 2016 02:25:10 GMT


> On March 4, 2016, 5:25 p.m., Joseph Wu wrote:
> > src/tests/persistent_volume_tests.cpp, line 89
> > <https://reviews.apache.org/r/44408/diff/1/?file=1281379#file1281379line89>
> >
> >     This entire helper is not needed anymore (due to implicit roles).
> 
> Guangya Liu wrote:
>     @Jopseph, why also remove acls here? The implicit roles will only create roles on
demand but what about acl?

By default, ACLs are "permissive".  So if a given permission does not exist, Mesos will allow
it.  

For the majority of the tests that use this helper, they are only using it to set initialize
the `role` so that a framework can register.  The ACL-specific tests set up ACLs separately.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44408/#review122163
-----------------------------------------------------------


On March 4, 2016, 6:24 p.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44408/
> -----------------------------------------------------------
> 
> (Updated March 4, 2016, 6:24 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-4868
>     https://issues.apache.org/jira/browse/MESOS-4868
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This fix removes the setting up of ACLs in PersistentVolumeTests
> as it is no longer needed any more with implicit roles (MESOS-4868).
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_tests.cpp bf19c81fbcf973d1ac27fbd42eedfd7118b7ba50 
> 
> Diff: https://reviews.apache.org/r/44408/diff/
> 
> 
> Testing
> -------
> 
> make check (in Ubuntu 14.04)
> 
> 
> Thanks,
> 
> Yong Tang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message