mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <mazumdar.an...@gmail.com>
Subject Re: Review Request 44274: Added the ability to stop running the scheduler library process.
Date Fri, 04 Mar 2016 00:03:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44274/
-----------------------------------------------------------

(Updated March 4, 2016, 12:03 a.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Made `stop()` explicitly terminate the process based on feedback from Vinod


Bugs: MESOS-4029
    https://issues.apache.org/jira/browse/MESOS-4029


Repository: mesos


Description
-------

This change adds the ability to stop running the scheduler library
process so that no future callbacks are delivered to the scheduler.

This helps us during testing to ensure no further callbacks happen
to stack allocated mock objects.


Diffs (updated)
-----

  include/mesos/v1/scheduler.hpp a0fb73be2178171497dcce5c497ca38c3002f667 
  src/scheduler/scheduler.cpp 7ea1c2567f37a73160bca346a25bb2f0c54e71a0 

Diff: https://reviews.apache.org/r/44274/diff/


Testing
-------

make check. This is used later in the chain when we move the interface to use the `stop()`
function.


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message