mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fan du <fan...@intel.com>
Subject Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.
Date Thu, 03 Mar 2016 05:47:15 GMT


> On 三月 2, 2016, 7:40 p.m., Greg Mann wrote:
> > Thanks Fan! I'm having a look at this now. Regarding the problems with review board
not wanting to update your previous RR, it's probably because it didn't find the review URL
in the commit message. In order to determine which RR it should update, the script looks for
a string like "Review: https://reviews.apache.org/r/44255/" in the commit message of the commit
you're pushing to review board. If you make sure that string (with the correct URL) is in
your commit message locally, review board should be able to find your previous review and
update it.

yes, it seems I recreated the commit message when rebasing without adding "Review: https://reviews.apache.org/r/44255".
squash the commits together should also works ok :) Thanks for your kindness.


- fan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44255/#review121705
-----------------------------------------------------------


On 三月 3, 2016, 5:40 a.m., fan du wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44255/
> -----------------------------------------------------------
> 
> (Updated 三月 3, 2016, 5:40 a.m.)
> 
> 
> Review request for mesos, Greg Mann, Guangya Liu, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-4492
>     https://issues.apache.org/jira/browse/MESOS-4492
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.
> 
> 
> Diffs
> -----
> 
>   docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 
>   src/master/master.cpp 8d6d3c6468c6b85fe09c33cf9747cc3d1f515ab9 
>   src/master/metrics.hpp 9d201fcce1c46a890c86a889ab31029f9a061561 
>   src/master/metrics.cpp 30c091198a8fdd6d6a957a351dc37d3dae7788e4 
>   src/tests/metrics_tests.cpp 419d275e0b32817388120222bd433ee6f4835efd 
> 
> Diff: https://reviews.apache.org/r/44255/diff/
> 
> 
> Testing
> -------
> 
> ChangLog:
> v2:
>   - Documenting those metrics
>   - Add test code for MetricsTest as suggested by Guangya
>   - post-review.py does not update original RR(https://reviews.apache.org/r/44058/),
but only create a new one even if I rebased.
> 
> 
> Tests:
> 1. make check GTEST_FILTER="MetricsTest.Master" on Centos-7 (3.10.0-123.el7.x86_640)
> 
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from MetricsTest
> [ RUN      ] MetricsTest.Master
> [       OK ] MetricsTest.Master (211 ms)
> [----------] 1 test from MetricsTest (211 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (244 ms total)
> [  PASSED  ] 1 test
> 
> 2. Verify its functionality with 'reserve' http endpoint as an test case
> 
> # curl http://ipdc02-kvm-guest2:5050/metrics/snapshot | python -mjson.tool | grep reserve
>     "master/messages_reserve_resource": 0.0,
>     "master/messages_unreserve_resource": 0.0,
> 
> 
> # curl -i -d slaveId=6250553a-2f39-4a92-9073-4618d130f433-S1  -d resources='[ { "name":
"cpus", "type": "SCALAR","scalar": { "value": 1 },"reservation":{"principal": "XiaoHaHa"}}
 ]' -X POST  ipdc02-kvm-guest2:5050/master/reserve
> HTTP/1.1 200 OK
> Date: Fri, 26 Feb 2016 19:59:01 GMT
> Content-Length: 0
> 
> # curl http://ipdc02-kvm-guest2:5050/metrics/snapshot  | python -mjson.tool | grep reserve
>     "master/messages_reserve_resource": 1.0,
>     "master/messages_unreserve_resource": 0.0,
> 
> 
> Thanks,
> 
> fan du
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message