mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 44087: Moved logic to assign process to freezer hierarchy into parentHook.
Date Thu, 03 Mar 2016 01:30:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44087/#review121741
-----------------------------------------------------------




src/slave/containerizer/mesos/linux_launcher.cpp (line 245)
<https://reviews.apache.org/r/44087/#comment183546>

    Two linespaces between functions ?



src/slave/containerizer/mesos/linux_launcher.cpp (line 246)
<https://reviews.apache.org/r/44087/#comment183545>

    For comments we are using // so
    s/\/*/\/\/



src/slave/containerizer/mesos/linux_launcher.cpp (line 250)
<https://reviews.apache.org/r/44087/#comment183549>

    alignment? 
    Should be Try<Nothing> assignFreezerHierarchy(
                      pid_t child,
                      ...,
                      ...)
                      
    Also we might want to have pid_t child as a const, since this is also immutable within
this function?



src/slave/containerizer/mesos/linux_launcher.cpp (line 262)
<https://reviews.apache.org/r/44087/#comment183573>

    Should fit in a single line?



src/slave/containerizer/mesos/linux_launcher.cpp (line 272)
<https://reviews.apache.org/r/44087/#comment183544>

    This could fit in a single line ?


- Avinash sridharan


On March 2, 2016, 1:49 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44087/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 1:49 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved logic to assign process to freezer hierarchy into parentHook.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/linux_launcher.cpp 9c80cfb621ef2e28aabfb2649846892964d2d4f3

> 
> Diff: https://reviews.apache.org/r/44087/diff/
> 
> 
> Testing
> -------
> 
> sudo make check (on Linux)
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message