mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 44274: Added the ability to stop running the scheduler library process.
Date Wed, 02 Mar 2016 23:59:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44274/#review121747
-----------------------------------------------------------




include/mesos/v1/scheduler.hpp (line 86)
<https://reviews.apache.org/r/44274/#comment183556>

    s/interface/library/
    
    what about calls? can they make calls after calling stop? looks like no from the implementation
below, but it needs to be commented here.
    
    also here it says "no callbacks" but down below it says "atmost one callback" ?



src/scheduler/scheduler.cpp (line 314)
<https://reviews.apache.org/r/44274/#comment183555>

    s/connection attempt/connected event/



src/scheduler/scheduler.cpp (line 409)
<https://reviews.apache.org/r/44274/#comment183554>

    s/change\/disconnection/detected event/



src/scheduler/scheduler.cpp (line 463)
<https://reviews.apache.org/r/44274/#comment183557>

    don't you need to guard this with !running.load() check?


- Vinod Kone


On March 2, 2016, 6:21 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44274/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 6:21 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4029
>     https://issues.apache.org/jira/browse/MESOS-4029
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds the ability to stop running the scheduler library
> process so that no future callbacks are delivered to the scheduler.
> 
> This helps us during testing to ensure no further callbacks happen
> to stack allocated mock objects.
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/scheduler.hpp a0fb73be2178171497dcce5c497ca38c3002f667 
>   src/scheduler/scheduler.cpp 7ea1c2567f37a73160bca346a25bb2f0c54e71a0 
> 
> Diff: https://reviews.apache.org/r/44274/diff/
> 
> 
> Testing
> -------
> 
> make check. This is used later in the chain when we move the interface to use the `stop()`
function.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message