mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 44273: Modified scheduler tests to use the callback interface.
Date Wed, 02 Mar 2016 23:50:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44273/#review121745
-----------------------------------------------------------


Fix it, then Ship it!




Thanks for the cleanup.


src/tests/scheduler_tests.cpp (lines 655 - 659)
<https://reviews.apache.org/r/44273/#comment183550>

    Split this expectation. The expectation for udpate2 should be set after #699.



src/tests/scheduler_tests.cpp (lines 1101 - 1105)
<https://reviews.apache.org/r/44273/#comment183551>

    split this. set the expectation for offers2 after #1124.



src/tests/scheduler_tests.cpp (lines 1202 - 1206)
<https://reviews.apache.org/r/44273/#comment183553>

    ditto. split please.


- Vinod Kone


On March 2, 2016, 8:28 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44273/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 8:28 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4798
>     https://issues.apache.org/jira/browse/MESOS-4798
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change modifies the existing scheduler tests to use the new callback
> interface introduced in MESOS-3339.
> 
> 
> Diffs
> -----
> 
>   src/tests/scheduler_tests.cpp 2b1693eaf1a6106f5e7d269e4e3f6c353dd6f017 
> 
> Diff: https://reviews.apache.org/r/44273/diff/
> 
> 
> Testing
> -------
> 
> make check (gtest_repeat=100)
> 
> I did not yet modify the maintenance tests due to a bug I found while
> modifying the tests. Filed MESOS-4831.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message