mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anurag Singh <anurag.prakash.si...@gmail.com>
Subject Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.
Date Wed, 02 Mar 2016 21:29:14 GMT


> On March 2, 2016, 9:20 p.m., Joseph Wu wrote:
> > Are you working with @mcavage?  (See https://reviews.apache.org/r/43269/)
> > 
> > Also, you might want to add this ticket to your reviews: https://issues.apache.org/jira/browse/MESOS-4610

That's correct. I'll update this with the ticket.

Based on your suggestions, I've split the change into 3 parts (I couldn't split the namespace
and refactoring changes because they are too tightly coupled). I've also added master_contender
and master_detector flags (https://reviews.apache.org/r/44288/) so users can specify the modules
to use.


- Anurag


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44287/#review121719
-----------------------------------------------------------


On March 2, 2016, 9:13 p.m., Anurag Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44287/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 9:13 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MasterContender and MasterDetector abstract classes can be subclassed by
> user-provided classes to allow for arbitrary contender/detector implementations.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/contender.hpp PRE-CREATION 
>   include/mesos/master/detector.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44287/diff/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/44289/.
> 
> 
> Thanks,
> 
> Anurag Singh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message