mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <>
Subject Re: Review Request 44275: Fixed flakiness in tests using the scheduler library.
Date Wed, 02 Mar 2016 21:08:13 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 2, 2016, 9:08 p.m.)

Review request for mesos and Vinod Kone.


Make review bot run again.

Bugs: MESOS-4029

Repository: mesos


This change fixes the tests using the scheduler library by
explicitly invoking `stop()` from the testing interface. This
ensures that no further callbacks are delivered to the scheduler.

For one-off async callbacks that are already on the libprocess queue
we need to do a `Clock::settle` to ensure they are executed before
the mock object goes out of scope.

Diffs (updated)

  src/tests/mesos.hpp 1d4f075e470a60040e17b9f011aea6202310c437 



make check + Induced a sleep in the async callbacks. Previously, the test used to crash but
with the fix it no longer crashes.


Anand Mazumdar

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message