mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Review Request 44278: Added HTTP scheduler stream IDs.
Date Wed, 02 Mar 2016 19:08:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44278/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-3583
    https://issues.apache.org/jira/browse/MESOS-3583


Repository: mesos


Description
-------

Added HTTP scheduler stream IDs.

In some failure scenarios involving highly-available HTTP schedulers with multiple instances,
it's possible for a non-leading instance to successfully make HTTP calls to the master. This
patch enables the master to use HTTP scheduler stream IDs to uniquely identify each HTTP subscription
stream, preventing any non-leading scheduler instance from making calls to the master. The
patch also adds stream ID support to the HTTP scheduler library.

Three new tests have been added in this patch: SchedulerHttpApiTest.TeardownWithoutStreamId,
SchedulerHttpApiTest.TeardownWrongStreamId, SchedulerHttpApiTest.SubscribeWithStreamId


Diffs
-----

  src/master/http.cpp 5e9e28e904ba0045ee27eb828f47231632a91d74 
  src/master/master.hpp 13c6ff153e77c527822309e787942eb463d59e7d 
  src/scheduler/scheduler.cpp 7ea1c2567f37a73160bca346a25bb2f0c54e71a0 
  src/tests/scheduler_http_api_tests.cpp 428e12646d80b45daec30cfe607b97f36170fdf5 

Diff: https://reviews.apache.org/r/44278/diff/


Testing
-------

New tests were added, and `make check` was used to test on OSX.

The new tests were run 1000 times to check for flakiness; no failures were observed.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message