mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <mazumdar.an...@gmail.com>
Subject Re: Review Request 44243: Updated master to ignore 'Subscribe.force' for HTTP framework.
Date Wed, 02 Mar 2016 16:59:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44243/#review121671
-----------------------------------------------------------


Fix it, then Ship it!




LGTM.


src/master/master.cpp (line 2107)
<https://reviews.apache.org/r/44243/#comment183438>

    Let's add a link to the JIRA for posterity since this behavior is different than for frameworks
connected via driver.


- Anand Mazumdar


On March 2, 2016, 1:10 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44243/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 1:10 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Greg Mann.
> 
> 
> Bugs: MESOS-4712
>     https://issues.apache.org/jira/browse/MESOS-4712
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Master always closes any old active streaming connection when it gets a
> SUBSCRIBE request.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp f242b70a0ebeff9cd3204343735b8615230a6108 
> 
> Diff: https://reviews.apache.org/r/44243/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message