mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 44269: Added the framework of 'network/cni' isolator.
Date Wed, 02 Mar 2016 16:24:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44269/#review121663
-----------------------------------------------------------




src/slave/containerizer/mesos/containerizer.cpp (lines 81 - 84)
<https://reviews.apache.org/r/44269/#comment183429>

    Lets do this in a separate patch once the implementation for the isolator is complete.



src/slave/containerizer/mesos/containerizer.cpp (line 223)
<https://reviews.apache.org/r/44269/#comment183428>

    We should introduce the `network/cni` isolator into the containerizer till the implementation
is complete. Lets remove this and submit it in a separate patch once the implementation is
complete.



src/slave/containerizer/mesos/isolators/network/cni.hpp (line 49)
<https://reviews.apache.org/r/44269/#comment183430>

    Doesn't this fit in a single line?



src/slave/containerizer/mesos/isolators/network/cni.cpp (line 41)
<https://reviews.apache.org/r/44269/#comment183436>

    explicit checks? (==0)



src/slave/containerizer/mesos/isolators/network/cni.cpp (line 42)
<https://reviews.apache.org/r/44269/#comment183431>

    s/directory/location
    
    Shouldn't the indentation be:
    return Error(
             "Failed to ..." +
             "..."



src/slave/containerizer/mesos/isolators/network/cni.cpp (line 46)
<https://reviews.apache.org/r/44269/#comment183437>

    Ditto on explicit checks.



src/slave/containerizer/mesos/isolators/network/cni.cpp (line 47)
<https://reviews.apache.org/r/44269/#comment183432>

    s/directory/location
    
    Ditto with the indentation.



src/slave/containerizer/mesos/isolators/network/cni.cpp (line 50)
<https://reviews.apache.org/r/44269/#comment183433>

    Should we be listing all the files in the config directory and reading the configs over
here?


- Avinash sridharan


On March 2, 2016, 3:25 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44269/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 3:25 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
> 
> 
> Bugs: MESOS-4759
>     https://issues.apache.org/jira/browse/MESOS-4759
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the framework of 'network/cni' isolator.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 9d29fad396cdac0f263c5d52460030630fc2dfaf 
>   src/Makefile.am fe549a881e778e094d3f957e5119eeb2f55e7915 
>   src/slave/containerizer/mesos/containerizer.cpp af3ff5750649497d8852b4761c78d4cae5455a02

>   src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44269/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message