mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 44163: Used temporary directory for fixture creating output files.
Date Wed, 02 Mar 2016 15:45:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44163/#review121660
-----------------------------------------------------------


Ship it!




Thanks for fixing this -- so looking foward to see parallel tests in action.


src/tests/state_tests.cpp (line 406)
<https://reviews.apache.org/r/44163/#comment183417>

    We need to assert here again as the baseclass Setup implementation may have returned with
an empty sandbox container.


- Till Toenshoff


On Feb. 29, 2016, 11:37 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44163/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2016, 11:37 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jan Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4806
>     https://issues.apache.org/jira/browse/MESOS-4806
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used temporary directory for fixture creating output files.
> 
> 
> Diffs
> -----
> 
>   src/tests/state_tests.cpp 0b0bc9cb1c6e4906aa65c113207e5a2d8ebe61d9 
> 
> Diff: https://reviews.apache.org/r/44163/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X, not optimized)
> 
> * before this patch running the test from a non-writable directory fails; with this patch
the test passes,
> * before this patch running gtest-parallel with filter `LevelDBState*` fails; with the
patch the test passes.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message