mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 44261: Introduced a RAII helper for process::metrics::Timer.
Date Wed, 02 Mar 2016 15:44:21 GMT


> On March 2, 2016, 2:52 p.m., Alexander Rukletsov wrote:
> > 3rdparty/libprocess/include/process/metrics/timer.hpp, line 147
> > <https://reviews.apache.org/r/44261/diff/1/?file=1276482#file1276482line147>
> >
> >     I don't think we put non-empty function body on the same line.

In fact we do (see e.g. Mesos style guide examples on lambdas), and is also consistent with
Google style guide (opening bracket on same line, closing on new line or same line as opening
bracket).

Broke this into multiple lines now nevertheless.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44261/#review121635
-----------------------------------------------------------


On March 2, 2016, 4:43 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44261/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 4:43 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4721
>     https://issues.apache.org/jira/browse/MESOS-4721
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/metrics/timer.hpp 0a9c0227c457c6c81a59f65f901a5464ee00983d

> 
> Diff: https://reviews.apache.org/r/44261/diff/
> 
> 
> Testing
> -------
> 
> `make check` succeeds under OS X (but this patch just adds a header). The follow-up patch
using this header does not need further changes here though.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message