mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.
Date Wed, 02 Mar 2016 15:43:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44260/
-----------------------------------------------------------

(Updated March 2, 2016, 4:43 p.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
-------

Introduced extra TU to make `metrics.hpp` and `hierarchical.hpp` independent.


Bugs: MESOS-4718
    https://issues.apache.org/jira/browse/MESOS-4718


Repository: mesos


Description (updated)
-------

See summary.


Diffs (updated)
-----

  src/Makefile.am 5d8fe8bf33acb352589b2b3e0341987f9a41bc17 
  src/master/allocator/mesos/hierarchical.hpp 3043888630b066505410d3b32c5b3f813cc458c1 
  src/master/allocator/mesos/hierarchical.cpp 24fa50f62dec10ed43089297473cc386d6ba2f78 
  src/master/allocator/mesos/metrics.hpp PRE-CREATION 
  src/master/allocator/mesos/metrics.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44260/diff/


Testing
-------

`make distcheck` on OS X, but this patch only adds an unused header. In the follow-up patch
#43879 we use the introduced class successfully.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message