mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 44261: Introduced a RAII helper for process::metrics::Timer.
Date Wed, 02 Mar 2016 13:52:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44261/#review121635
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/include/process/metrics/timer.hpp (line 137)
<https://reviews.apache.org/r/44261/#comment183382>

    I think you can omit the `process::metrics::` prefix here and below.
    
    For consistency, please s/`timer_`/`_timer`.



3rdparty/libprocess/include/process/metrics/timer.hpp (line 147)
<https://reviews.apache.org/r/44261/#comment183383>

    I don't think we put non-empty function body on the same line.


- Alexander Rukletsov


On March 2, 2016, 10:34 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44261/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 10:34 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4721
>     https://issues.apache.org/jira/browse/MESOS-4721
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced a RAII helper for process::metrics::Timer.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/metrics/timer.hpp 0a9c0227c457c6c81a59f65f901a5464ee00983d

> 
> Diff: https://reviews.apache.org/r/44261/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message