mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 44122: Add tests for recovering orphaned persistent volumes.
Date Wed, 02 Mar 2016 03:39:09 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 1, 2016, 7:39 p.m.)

Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Looks like that `flags.work_dir` assignment has no effect.

Bugs: MESOS-4824

Repository: mesos


Based on DockerContainerizerTest.ROOT_DOCKER_RecoverOrphanedPersistentVolumes.  This tests
orphaned persistent volumes and the MesosContainerizer, with and without rootfs.

Diffs (updated)

  src/tests/containerizer/filesystem_isolator_tests.cpp 6a60962b4593b3521c182c7320331743ccffd4ba

  src/tests/persistent_volume_tests.cpp bf19c81fbcf973d1ac27fbd42eedfd7118b7ba50 



As of this patch, thise tests do not pass:

1) The `filesystem/linux` isolator recovers the persistent volume as a "known" orphan.  Known
orphans are not cleaned up immediately.
  - We only detect rootfs mounts currently.  i.e. when the root of the mount is inside the
agent's `<work_dir>/slaves`.
  - Persistent volume mounts have roots under `<work_dir>/volumes`.
2) When the containerizer removes this orphan, the `filesystem/linux` isolator has no `ContainerInfo`
about it.  The isolator does not look up the mount table again, and the isolator ignores the
3) Test checks the mount table and sees the mount is still present -> test failed.


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message