mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Timothy Chen <tnac...@apache.org>
Subject Re: Review Request 44247: Remove race condition from filesystem_isolator_tests.cpp.
Date Wed, 02 Mar 2016 01:46:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44247/#review121565
-----------------------------------------------------------



Good catch! I used to need these but after some reviews of changing how to use persistent
volumes I no longer need them.

- Timothy Chen


On March 2, 2016, 1:44 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44247/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 1:44 a.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Offers2 is never used nor waited for which can result in it not being called.
> SlaveId is an unused variable.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 6a60962b4593b3521c182c7320331743ccffd4ba

> 
> Diff: https://reviews.apache.org/r/44247/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message