mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 44196: Fixed MesosContainerizer orphaned persistent volume recovery.
Date Wed, 02 Mar 2016 01:11:15 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 1, 2016, 5:11 p.m.)

Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Rework the fix into what we (Jie & I) discussed offline.

Summary (updated)

Fixed MesosContainerizer orphaned persistent volume recovery.

Bugs: MESOS-4824

Repository: mesos

Description (updated)

Adds extra mount-table checking logic specifically for orphaned persistent volumes that can
be safely cleaned up.  This includes "known" orphans (i.e. containers detected via the `Launcher`).

Also adds some extra helpers in `slave::paths`.

Diffs (updated)

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 7fdf518deeb388218438245623719f41613d031b

  src/slave/paths.hpp 5ae3a2b86bf76859e0ffb78be2644af56bc88d49 
  src/slave/paths.cpp 6d9dad59386fb890267923f35edabbdf54fb39c6 
  src/tests/paths_tests.cpp 4c15ebc514e5d1714b243432eeff5377bb21b93f 


Testing (updated)

Tests added in previous review now pass.  i.e.
GLOG_v=1 sudo -E bin/ --gtest_filter="*MesosContainerizerRecoverOrphanedVolumes*0"
GLOG_v=1 sudo -E bin/ --gtest_filter="*ChangeRootFilesystemOrphanedPersistentVolume"

Confirmed that the right log messages show up:
I0302 00:51:01.100466  1610 linux.cpp:782] Unmounting volume '/tmp/DiskResource_PersistentVolumeTest_ROOT_MesosContainerizerRecoverOrphanedVolumes_0_smk5ZU/slaves/a6cd56eb-a106-4c2a-b2c7-b3b97a7a308f-S0/frameworks/a6cd56eb-a106-4c2a-b2c7-b3b97a7a308f-0000/executors/cdbae703-603d-4e4c-a026-326dbc8c9ce2/runs/8742378c-9a5d-43d6-af31-0c7fe1f5c4c7/path1'
for container 8742378c-9a5d-43d6-af31-0c7fe1f5c4c7
I0302 00:51:01.100538  1610 linux.cpp:798] Ignoring unmounting sandbox/work directory for
container 8742378c-9a5d-43d6-af31-0c7fe1f5c4c7


CI test results (running)...


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message