mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Klaus Ma <klaus1982...@gmail.com>
Subject Re: Review Request 44236: Update slave's version after re-registering.
Date Wed, 02 Mar 2016 00:01:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44236/
-----------------------------------------------------------

(Updated March 2, 2016, 8:01 a.m.)


Review request for mesos and Joris Van Remoortere.


Changes
-------

Add JIRA/bugs #.


Bugs: MESOS-4825
    https://issues.apache.org/jira/browse/MESOS-4825


Repository: mesos


Description
-------

Update slave's version after re-registering.


Diffs
-----

  src/master/master.hpp 13c6ff153e77c527822309e787942eb463d59e7d 
  src/master/master.cpp f242b70a0ebeff9cd3204343735b8615230a6108 

Diff: https://reviews.apache.org/r/44236/diff/


Testing
-------

Test it manually.

Test Steps:
1. Start 0.28.0 master
2. Start 0.28.0 slave
3. Stop 0.28.0 slave
4. Start 0.27.0 slave with the same work directory
 
Test Results:

```
Klauss-MacBook-Pro:mesos klaus$ curl http://localhost:5050/slaves | python -m json.tool
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   588  100   588    0     0  79277      0 --:--:-- --:--:-- --:--:-- 84000
{
    "slaves": [
        {
            "active": true,
            "attributes": {},
            "hostname": "192.168.1.101",
            "id": "8635c7aa-6c20-44ec-ac3f-d69aec48f243-S0",
            "offered_resources": {
                "cpus": 0.0,
                "disk": 0.0,
                "mem": 0.0
            },
            "offered_resources_full": [],
            "pid": "slave(1)@192.168.1.101:5051",
            "registered_time": 1456874482.32198,
            "reserved_resources": {},
            "reserved_resources_full": {},
            "resources": {
                "cpus": 8.0,
                "disk": 470832.0,
                "mem": 15360.0,
                "ports": "[31000-32000]"
            },
            "unreserved_resources": {
                "cpus": 8.0,
                "disk": 470832.0,
                "mem": 15360.0,
                "ports": "[31000-32000]"
            },
            "used_resources": {
                "cpus": 0.0,
                "disk": 0.0,
                "mem": 0.0
            },
            "used_resources_full": [],
            "version": "0.28.0"
        }
    ]
}
Klauss-MacBook-Pro:mesos klaus$ curl http://localhost:5050/slaves | python -m json.tool
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   625  100   625    0     0  85592      0 --:--:-- --:--:-- --:--:-- 89285
{
    "slaves": [
        {
            "active": true,
            "attributes": {},
            "hostname": "192.168.1.101",
            "id": "8635c7aa-6c20-44ec-ac3f-d69aec48f243-S0",
            "offered_resources": {
                "cpus": 0.0,
                "disk": 0.0,
                "mem": 0.0
            },
            "offered_resources_full": [],
            "pid": "slave(1)@192.168.1.101:5051",
            "registered_time": 1456874482.32198,
            "reregistered_time": 1456874497.25686,
            "reserved_resources": {},
            "reserved_resources_full": {},
            "resources": {
                "cpus": 8.0,
                "disk": 470832.0,
                "mem": 15360.0,
                "ports": "[31000-32000]"
            },
            "unreserved_resources": {
                "cpus": 8.0,
                "disk": 470832.0,
                "mem": 15360.0,
                "ports": "[31000-32000]"
            },
            "used_resources": {
                "cpus": 0.0,
                "disk": 0.0,
                "mem": 0.0
            },
            "used_resources_full": [],
            "version": "0.27.0"
        }
    ]
}
```


Thanks,

Klaus Ma


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message