mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 43908: Stout:[2/2] Added significant test coverage of `os::rmdir`.
Date Tue, 01 Mar 2016 23:21:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43908/#review121532
-----------------------------------------------------------




3rdparty/libprocess/3rdparty/stout/Makefile.am (line 48)
<https://reviews.apache.org/r/43908/#comment183251>

    style



3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp (line 32)
<https://reviews.apache.org/r/43908/#comment183253>

    We have `hashset<string>::EMPTY`.
    `const hashset<string>& EMPTY = hashset<string>::EMPTY;`



3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp (lines 51 - 91)
<https://reviews.apache.org/r/43908/#comment183256>

    Can you add a TODO to parameterize this test?
    It's the same code copy pasted with 1 difference: relative vs. absolute path.



3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp (line 172)
<https://reviews.apache.org/r/43908/#comment183257>

    What is this?



3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp (lines 163 - 194)
<https://reviews.apache.org/r/43908/#comment183259>

    I don't understand why these got removed.
    They are not covered by the tests your introduced.


- Joris Van Remoortere


On Feb. 25, 2016, 7:40 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43908/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2016, 7:40 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere,
Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout:[2/2] Added significant test coverage of `os::rmdir`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 756aa29ed134bf10a645af7f6562f86dc8e488f5

>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 3c65d0422dc6e198180d53d1c9e6cb2839137434

>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp d0592ef8a774d380e9df66b7e623eb72b29a28b3

>   3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp a2bc5c40167896a3df2cfb5b1f3cf58c20ea1422

> 
> Diff: https://reviews.apache.org/r/43908/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message