mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <mazumdar.an...@gmail.com>
Subject Re: Review Request 43846: Added support for specifying detector to the callback interface.
Date Sat, 27 Feb 2016 04:48:16 GMT


> On Feb. 27, 2016, 2:43 a.m., Vinod Kone wrote:
> > src/scheduler/scheduler.cpp, lines 637-638
> > <https://reviews.apache.org/r/43846/diff/1/?file=1264752#file1264752line637>
> >
> >     Yikes. Why are you doing it like this, instead of passing detector as an optional
argument to the MesosProcess?

Agreed, my bad. I had tried to follow the existing pattern used in `TestMesosSchedulerDriver`
but should have avoided it.


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43846/#review121054
-----------------------------------------------------------


On Feb. 22, 2016, 8:24 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43846/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2016, 8:24 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4686
>     https://issues.apache.org/jira/browse/MESOS-4686
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds support for passing in a master detector object to the callback interface.
This can be used for testing master failover scenarios similar to how the driver already does
it.
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/scheduler.hpp 5e462c13ec2715888247eb7b4dc7a2b1d53e6bb1 
>   src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75 
>   src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0 
> 
> Diff: https://reviews.apache.org/r/43846/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message